Skip to content

update service api model #5100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 18, 2024
Merged

update service api model #5100

merged 2 commits into from
Nov 18, 2024

Conversation

@Will-ShaoHua
Copy link
Contributor

@Will-ShaoHua Will-ShaoHua commented Nov 18, 2024

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Will-ShaoHua Will-ShaoHua requested a review from a team as a code owner November 18, 2024 20:17
@Will-ShaoHua Will-ShaoHua marked this pull request as draft November 18, 2024 20:21
@Will-ShaoHua Will-ShaoHua marked this pull request as ready for review November 18, 2024 22:15
@Will-ShaoHua Will-ShaoHua merged commit 78edb89 into aws:main Nov 18, 2024
12 of 13 checks passed
@Will-ShaoHua Will-ShaoHua deleted the api branch November 18, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rli rli rli approved these changes

@andrewyuq andrewyuq andrewyuq approved these changes

@ashishrp-aws ashishrp-aws ashishrp-aws approved these changes

+1 more reviewer

@KevinDing1 KevinDing1 KevinDing1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Will-ShaoHua @rli @andrewyuq @KevinDing1 @ashishrp-aws